Refactor collection initializers to use C# 12 collection expressions

This commit updates various files across the Core and WebApp projects to replace traditional collection initializers with C# 12 collection expressions. Changes include modifications to EventAssignment.cs, TeamScheduler_DecisionTree.cs, CareerField.cs, EventDefinition.cs, and several components in the WebApp. These updates enhance code readability and maintainability by adhering to modern C# syntax standards.

Core/Entities/CareerField.cs

@@ -43,13 +43,10 @@ public class CareerField
 		Id = id;
 		Name = name;
 		Description = description;
-		DirectCareerMatches = directCareerMatches ?? Array.Empty<string>();
-		PatternKeywords = patternKeywords ?? Array.Empty<string>();
+		DirectCareerMatches = directCareerMatches ?? [];
+		PatternKeywords = patternKeywords ?? [];
 	}
 
-	public override string ToString()
-	{
-		return Name;
-	}
+	public override string ToString() => Name;
 }
 

Core/Entities/EventDefinition.cs

@@ -37,21 +37,6 @@ public class EventDefinition
 		=> SemifinalistActivity != null && (SemifinalistActivity.Contains("Interview") || SemifinalistActivity.Contains("Presentation"));
 
 	public bool OnSiteActivity { get; set; }
-    //=> SemifinalistActivity != null
-    //         && (SemifinalistActivity.Contains("Challenge")
-    //          || SemifinalistActivity.Contains("Race")
-    //          || SemifinalistActivity.Contains("Speech")
-    //          || SemifinalistActivity.Contains("Test")
-    //          || SemifinalistActivity.Contains("Flight")
-    //          || Name.Contains("Leadership")
-    //          || Name.Contains("Forensic")
-    //          || Name.Contains("Flight")
-    //          || Name.Contains("Coding")
-    //          || SemifinalistActivity.Contains("Debate")
-    //          || SemifinalistActivity.Contains("Photography")
-    //          || SemifinalistActivity.Contains("Build")
-    //          || Name.Contains("Chapter")
-    //          || Name.Contains("Podcast"));
 
     [StringLength(1024)]
 	public string? Notes { get; set; }
@@ -79,15 +64,12 @@ public class EventDefinition
     public string? Description { get; set; }
 	public int? LevelOfEffort { get; set; }
 
-	public ICollection<Career> RelatedCareers { get; set; } = new List<Career>();
+	public ICollection<Career> RelatedCareers { get; set; } = [];
 
 	[System.ComponentModel.DataAnnotations.Schema.NotMapped]
 	public string? RelatedCareersText { get; set; }
 
-	public override string ToString()
-	{
-		return Name;
-	}
+	public override string ToString() => Name;
 
 	public static readonly EventDefinition GeneralSchedule = new(){Name = "General Schedule"};
 	public static readonly EventDefinition MeetTheCandidates = new(){Name = "Meet the Candidates"};