feat: add optional student nickname for informal display

Keep legal first and last names for formal lists; show DisplayFirstName on teams, calendars, and import matching so two Josiahs can be told apart. Co-authored-by: Cursor <cursoragent@cursor.com>
2026-09-12 00:06:33 -04:00
parent c03ffc0833
commit 29101e2ead
35 changed files with 516 additions and 41 deletions
@@ -68,6 +68,21 @@ public class StudentEventRankingParser_Tests
        Assert.That(result.Matches[0].Ranking.Student, Is.SameAs(_aria));
    }

+    [Test]
+    public void Parse_NicknamePlusLastName_MatchesStudent()
+    {
+        var jo = StudentBuilder.Create("Josiah", "Brown").WithNickname("Jo").Build();
+
+        var result = ParseCsv("""
+            Student Name,1
+            Jo Brown,Coding
+            """, [jo], _events);
+
+        Assert.That(result.IsSuccess, Is.True);
+        Assert.That(result.Matches, Has.Count.EqualTo(1));
+        Assert.That(result.Matches[0].Ranking.Student, Is.SameAs(jo));
+    }
+
    [Test]
    public void Parse_ShortName_MatchesEvent()
    {