From 057aa31bf8e063f517f43a76da7e6b4b03b825da Mon Sep 17 00:00:00 2001 From: James Kolpack Date: Fri, 26 Dec 2025 16:54:16 -0500 Subject: [PATCH] Enhance Event Rank Color System --- .../Features/Students/EventRanking.razor | 14 +++++++--- .../Teams/Components/TeamStudents.razor | 26 +++++++++++++------ docs/plans/style-improvements.md | 4 +-- 3 files changed, 30 insertions(+), 14 deletions(-) diff --git a/WebApp/Components/Features/Students/EventRanking.razor b/WebApp/Components/Features/Students/EventRanking.razor index 149e77c..27001c9 100644 --- a/WebApp/Components/Features/Students/EventRanking.razor +++ b/WebApp/Components/Features/Students/EventRanking.razor @@ -49,9 +49,12 @@ else @if (st != null) { - @st.EventDefinition.ShortName  - - + + + @st.EventDefinition.ShortName  + + + } } @@ -86,7 +89,10 @@ else @if (student != null) { - @student.Item1.FirstName + + + @student.Item1.FirstName + } } diff --git a/WebApp/Components/Features/Teams/Components/TeamStudents.razor b/WebApp/Components/Features/Teams/Components/TeamStudents.razor index 5665764..6f3e4f5 100644 --- a/WebApp/Components/Features/Teams/Components/TeamStudents.razor +++ b/WebApp/Components/Features/Teams/Components/TeamStudents.razor @@ -6,19 +6,29 @@ .Find(er => er.EventDefinition == Team.Event)?.Rank ?? 10) .ThenBy(s => s.Grade + s.TsaYear)) { - var eventRank = + var eventRank = student.EventRankings .Find(e => e.EventDefinition == Team.Event)?.Rank; var color = AppIcons.RankedEventColor(eventRank ?? 0); var captain = Team.Captain != null && Team.Captain.Equals(student); + var rankLabel = eventRank.HasValue ? $"Rank {eventRank}" : "Unranked"; - - @student.FirstName - @if (captain && Team.Event.EventFormat != EventFormat.Individual) - { - - } - + + + @if (eventRank.HasValue) + { + + } + @student.FirstName + @if (captain && Team.Event.EventFormat != EventFormat.Individual) + { + + } + + } @code { diff --git a/docs/plans/style-improvements.md b/docs/plans/style-improvements.md index bd7e355..ad120fb 100644 --- a/docs/plans/style-improvements.md +++ b/docs/plans/style-improvements.md @@ -224,7 +224,7 @@ Wrap main page content in consistent containers: --- -### 8. Enhance Event Rank Color System +### 8. Enhance Event Rank Color System ✅ COMPLETED **Current State**: Good color-coding system (ranks 1-6) defined in app.css **Potential Enhancement**: @@ -336,7 +336,7 @@ Consider using MudChip components with rank colors for better visual distinction ### Phase 3: Enhancements (Nice to Have) 7. Audit and ensure button hierarchy consistency -8. Enhance event rank visualization +8. ✅ Enhance event rank visualization 9. Improve form layout grouping 10. Add micro-interactions and transitions