Set password operational

Sitewide plan for status messages

Web/Controllers/UserController.cs

@@ -2,8 +2,6 @@
 using System.Linq;
 using System.Web.Mvc;
 using System.Web.Security;
-using MileageTraker.Web.Attributes;
-using MileageTraker.Web.Models;
 using MileageTraker.Web.ViewModels.User;
 
 namespace MileageTraker.Web.Controllers
@@ -41,8 +39,6 @@ namespace MileageTraker.Web.Controllers
         {
             if (ModelState.IsValid)
             {
-	            var hasRoles = viewModel.Roles != null && viewModel.Roles.Any();
-
 	            MembershipCreateStatus membershipCreateStatus;
 	            var membershipUser = 
 					Membership.CreateUser(
@@ -51,7 +47,7 @@ namespace MileageTraker.Web.Controllers
 						viewModel.Email,
 						null,
 						null,
-						hasRoles,
+						true,
 						out membershipCreateStatus);
 
 	            if (membershipUser == null)
@@ -61,19 +57,19 @@ namespace MileageTraker.Web.Controllers
 					return View(viewModel);
 	            }
 
-	            if (hasRoles)
+				if (viewModel.Roles != null && viewModel.Roles.Any())
 				{
 					Roles.AddUserToRoles(
 						membershipUser.UserName,
 						viewModel.Roles);
 				}
 
-	            var user = DataService.GetUser(
-					(Guid) membershipUser.ProviderUserKey);
+	            var user = DataService.GetUser((Guid) membershipUser.ProviderUserKey);
 	            user.FullName = viewModel.FullName;
 				DataService.UpdateUserPersonalInfo(user);
 
-	            return RedirectToAction("Index");
+				TempData["StatusMessage"] = "User " + user.Username + " created";
+				return RedirectToAction("Index");
             }
 
 			viewModel.AvailableRoles = Roles.GetAllRoles();
@@ -87,20 +83,72 @@ namespace MileageTraker.Web.Controllers
             {
                 return HttpNotFound();
             }
-            return View(user);
+
+			var vm = new EditUserViewModel(user)
+			{
+				Roles = Roles.GetRolesForUser(user.Username),
+				AvailableRoles = Roles.GetAllRoles()
+			};
+
+			return View(vm);
         }
 
         [HttpPost]
-        public ActionResult Edit(User user)
+		public ActionResult Edit(EditUserViewModel viewModel)
         {
             if (ModelState.IsValid)
             {
-                DataService.UpdateUser(user);
-                return RedirectToAction("Index");
+				var user = DataService.GetUser(viewModel.UserId);
+				viewModel.UpdateUser(user);
+                DataService.UpdateUserPersonalInfo(user);
+
+				Roles.RemoveUserFromRoles(user.Username, Roles.GetAllRoles());
+				if (viewModel.Roles != null && viewModel.Roles.Any())
+				{
+					Roles.AddUserToRoles(
+						user.Username,
+						viewModel.Roles);
+				}
+
+				TempData["StatusMessage"] = "Changes saved for " + user.Username;
+				return RedirectToAction("Index");
             }
-            return View(user);
+			return View(viewModel);
         }
 
+		public ActionResult SetPassword(Guid id)
+		{
+			var user = Membership.GetUser(id);
+			if (user == null)
+			{
+				return HttpNotFound();
+			}
+			var viewModel = new SetPasswordViewModel {UserId = id, Username = user.UserName};
+			return View(viewModel);
+		}
+
+		[HttpPost]
+		public ActionResult SetPassword(SetPasswordViewModel viewModel)
+		{
+			if (ModelState.IsValid)
+			{
+				// ChangePassword will throw an exception rather than return false in certain failure scenarios.
+				try
+				{
+					DataService.UpdateUserPassword(viewModel.UserId, viewModel.NewPassword);
+					TempData["StatusMessage"] = "Password set for " + viewModel.Username;
+					return RedirectToAction("Details", new { id = viewModel.UserId});
+				}
+				catch (Exception)
+				{
+					ModelState.AddModelError("", "The new password is invalid.");
+				}
+			}
+
+			// If we got this far, something failed, redisplay form
+			return View(viewModel);
+		}
+
 		private static string ErrorCodeToString(MembershipCreateStatus createStatus)
 		{
 			// See http://go.microsoft.com/fwlink/?LinkID=177550 for